Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/990#discussion_r13558814
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -154,6 +155,10 @@ object NullPropagation extends Rule[LogicalPlan] {
             case left :: Literal(null, _) :: Nil => Literal(null, e.dataType)
             case _ => e
           }
    +      case e: CaseConversionExpression => e.children match {
    --- End diff --
    
    This case would be more generally handled by constant folding.  Can you 
override foldable in these expressions to be true if the child is foldable?  
Also please fix the toString methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to