Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7880#discussion_r36053652
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -231,7 +235,7 @@ class CodeGenContext {
case dt: DataType if isPrimitiveType(dt) => s"($c1 > $c2 ? 1 : $c1 <
$c2 ? -1 : 0)"
case BinaryType =>
s"org.apache.spark.sql.catalyst.util.TypeUtils.compareBinary($c1, $c2)"
case NullType => "0"
- case schema: StructType if schema.supportOrdering(schema) =>
+ case schema: StructType =>
--- End diff --
We don't need this here since GenerateOrdering.genComparisons already
throws an exception if it is for unsupported type.
This is actually not a user facing exception - it can only happen if we
have a bug somewhere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
