Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7883#discussion_r36054669
--- Diff: dev/run-tests.py ---
@@ -385,6 +385,10 @@ def run_sparkr_tests():
if which("R"):
run_cmd([os.path.join(SPARK_HOME, "R", "install-dev.sh")])
+ # R style check should be executed after `install-dev.sh`.
+ # Since warnings about `no visible global function definition`
appear
+ # without the installation. SEE ALSO: SPARK-9121.
+ run_cmd([os.path.join(SPARK_HOME, "dev", "lint-r")])
--- End diff --
If we place the lint check in `run_sparkr_tests` then this may result in us
running those lint checks after running other tests, which will make it take
longer to discover R style failures in scenarios where non-R tests had to be
run. As a result, I wonder if we should place this linting check near line
488, by the existing `run_python_style_checks()` call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
