Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7774#discussion_r36058609
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala ---
    @@ -0,0 +1,230 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.ui
    +
    +import javax.servlet.http.HttpServletRequest
    +
    +import scala.xml.Node
    +
    +import org.apache.commons.lang3.StringEscapeUtils
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.ui.{UIUtils, WebUIPage}
    +
    +private[ui] class AllExecutionsPage(parent: SQLTab) extends WebUIPage("") 
with Logging {
    +
    +  private val listener = parent.listener
    +
    +  override def render(request: HttpServletRequest): Seq[Node] = {
    +    val currentTime = System.currentTimeMillis()
    +    val content = listener.synchronized {
    +      var _content: Seq[Node] = Nil
    +      if (listener.getRunningExecutions.nonEmpty) {
    +        _content ++=
    +          new RunningExecutionTable(
    +            parent, "Running Queries", currentTime,
    +            
listener.getRunningExecutions.sortBy(_.submissionTime).reverse).toNodeSeq
    +      }
    +      if (listener.getCompletedExecutions.nonEmpty) {
    +        _content ++=
    +          new CompletedExecutionTable(
    +            parent, "Completed Queries", currentTime,
    +            
listener.getCompletedExecutions.sortBy(_.submissionTime).reverse).toNodeSeq
    +      }
    +      if (listener.getFailedExecutions.nonEmpty) {
    +        _content ++=
    +          new FailedExecutionTable(
    +            parent, "Failed Queries", currentTime,
    +            
listener.getFailedExecutions.sortBy(_.submissionTime).reverse).toNodeSeq
    +      }
    +      _content
    +    }
    +    UIUtils.headerSparkPage("SQL", content, parent, Some(5000))
    +  }
    +}
    +
    +private[ui] abstract class ExecutionTable(
    +    parent: SQLTab,
    +    tableName: String,
    +    currentTime: Long,
    +    executionUIDatas: Seq[SparkSQLExecutionUIData],
    +    showRunningJobs: Boolean,
    +    showSucceededJobs: Boolean,
    +    showFailedJobs: Boolean) {
    +
    +  protected def baseHeader: Seq[String] = Seq(
    +    "ID",
    +    "Description",
    +    "Submitted",
    +    "Duration")
    +
    +  protected def header: Seq[String]
    +
    +  protected def row(currentTime: Long, executionUIData: 
SparkSQLExecutionUIData): Seq[Node] = {
    +    val submissionTime = executionUIData.submissionTime
    +    val duration = executionUIData.completionTime.getOrElse(currentTime) - 
submissionTime
    +
    +    val runningJobs = executionUIData.runningJobs.map { jobId =>
    +      <a href={jobURL(jobId)}>{jobId.toString}</a><br/>
    +    }
    +    val succeededJobs = executionUIData.succeededJobs.sorted.map { jobId =>
    +      <a href={jobURL(jobId)}>{jobId.toString}</a><br/>
    +    }
    +    val failedJobs = executionUIData.failedJobs.sorted.map { jobId =>
    +      <a href={jobURL(jobId)}>{jobId.toString}</a><br/>
    +    }
    +    <tr>
    +      <td>
    +        {executionUIData.executionId.toString}
    +      </td>
    +      <td>
    +        {descriptionCell(executionUIData)}
    +      </td>
    +      <td sorttable_customkey={submissionTime.toString}>
    +        {UIUtils.formatDate(submissionTime)}
    +      </td>
    +      <td sorttable_customkey={duration.toString}>
    +        {UIUtils.formatDuration(duration)}
    +      </td>
    +      {if (showRunningJobs) {
    +        <td>
    +          {runningJobs}
    +        </td>
    +      }}
    +      {if (showSucceededJobs) {
    +        <td>
    +          {succeededJobs}
    +        </td>
    +      }}
    +      {if (showFailedJobs) {
    +        <td>
    +          {failedJobs}
    +        </td>
    +      }}
    +      {detailCell(executionUIData.physicalPlanDescription)}
    +    </tr>
    +  }
    +
    +  private def descriptionCell(execution: SparkSQLExecutionUIData): 
Seq[Node] = {
    +    val details = if (execution.details.nonEmpty) {
    +      <span 
onclick="this.parentNode.querySelector('.stage-details').classList.toggle('collapsed')"
    +            class="expand-details">
    +        +details
    +      </span> ++
    +      <div class="stage-details collapsed">
    +        <pre>{execution.details}</pre>
    +      </div>
    +    }
    +
    +    val desc = {
    +      <a 
href={executionURL(execution.executionId)}>{execution.description}</a>
    +    }
    +
    +    <div>{desc} {details}</div>
    +  }
    +
    +  private def detailCell(physicalPlan: String): Seq[Node] = {
    +    val isMultiline = physicalPlan.indexOf('\n') >= 0
    +    val summary = StringEscapeUtils.escapeHtml4(
    +      if (isMultiline) {
    +        physicalPlan.substring(0, physicalPlan.indexOf('\n'))
    +      } else {
    +        physicalPlan
    +      })
    +    val details = if (isMultiline) {
    +      // scalastyle:off
    +      <span 
onclick="this.parentNode.querySelector('.stacktrace-details').classList.toggle('collapsed')"
    +            class="expand-details">
    +        + details
    +      </span> ++
    +        <div class="stacktrace-details collapsed">
    +          <pre>{physicalPlan}</pre>
    +        </div>
    +      // scalastyle:on
    +    } else {
    +      ""
    +    }
    +    <td>{summary}{details}</td>
    +  }
    +
    +  def toNodeSeq: Seq[Node] = {
    +    <div>
    +      <h4>{tableName}</h4>
    +      {UIUtils.listingTable[SparkSQLExecutionUIData](header, 
row(currentTime, _), executionUIDatas)}
    +    </div>
    +  }
    +
    +  private def jobURL(jobId: Long): String =
    +    "%s/jobs/job?id=%s".format(UIUtils.prependBaseUri(parent.basePath), 
jobId)
    +
    +  private def executionURL(executionID: Long): String =
    +    
"%s/sql/execution?id=%s".format(UIUtils.prependBaseUri(parent.basePath), 
executionID)
    +}
    +
    +private[ui] class RunningExecutionTable(
    +    parent: SQLTab,
    +    tableName: String,
    +    currentTime: Long,
    +    executionUIDatas: Seq[SparkSQLExecutionUIData])
    +  extends ExecutionTable(
    +    parent,
    +    tableName,
    +    currentTime,
    +    executionUIDatas,
    +    showRunningJobs = true,
    +    showSucceededJobs = true,
    +    showFailedJobs = true) {
    --- End diff --
    
    > is this really a RunningExecutionTable if it shows everything? Maybe this 
should be AllExecutionsTable or something
    
    Yes. This is a table only for executions that have running jobs. It means 
the execution is still running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to