Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7892#discussion_r36061326
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoinerBitsetSuite.scala
---
@@ -91,8 +92,9 @@ class GenerateUnsafeRowJoinerBitsetSuite extends
SparkFunSuite {
private def createUnsafeRow(numFields: Int): UnsafeRow = {
val row = new UnsafeRow
val sizeInBytes = numFields * 8 + ((numFields + 63) / 64) * 8
- val buf = new Array[Byte](sizeInBytes)
- row.pointTo(buf, numFields, sizeInBytes)
+ val offset = numFields * 8
--- End diff --
ok maybe say that in the comment - right now this number doesn't feel
random; it feels as if there is an explicit choice here :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
