Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/7802#issuecomment-127346914
Looks ok as far as I can tell. I generally find it weird to use traits for
public APIs (too easy to break compatibility), but then all the API here is
scala, so maybe it's not a big deal. I also wonder if there's a test that can
be written to ensure that we're not mistakenly registering two sources with the
same name.
And finally, `ServiceLoader` may have some funny semantics when used with
`userClassPathFirst`, given the current implementation of
`ChildFirstURLClassLoader`. Might be worth it to make a note to look at that
behavior in more detail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
