Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7770#discussion_r36111035
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -258,6 +259,24 @@ class SQLQuerySuite extends QueryTest with
BeforeAndAfterAll with SQLTestUtils {
}
}
+ private def testCodeGen(sqlText: String, expectedResults: Seq[Row]):
Unit = {
+ val df = sql(sqlText)
+ // First, check if we have GeneratedAggregate.
+ val hasGeneratedAgg = df.queryExecution.executedPlan match {
--- End diff --
I don't think that we can change this from `collect` to `match`: `collect`
will try to match the pattern anywhere in the query tree, whereas `match ` will
only match at the root of the query plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
