Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/895#issuecomment-45560792
Changes made:
1. Separated the classes into different files in package spark.util.logging.
2. Consolidated the logic to get the sorted list of files in
`RollingFileAppender.getSortedRolledOverFiles` with comments on the sorting
logic.
3. Tied file naming pattern with RollingPolicy as it is more closely
associated with the rolling strategy (time or size).
4. Changed configuration parameters to as discussed in the comments.
This is ready to be reviewed again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
