Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7774#issuecomment-127434198
Reviewed 4 of 20 files at r1, 3 of 13 files at r2, 5 of 9 files at r3, 11
of 11 files at r4.
Review status: all files reviewed at latest revision, 67 unresolved
discussions, some commit checks failed.
---
<sup>**[core/src/main/scala/org/apache/spark/executor/Executor.scala, line
304
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvpqTaCSdVxTguY_XBY)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/core/src/main/scala/org/apache/spark/executor/Executor.scala#L304)):</sup>
this may not be necessary. I think the semantics of accumulators are that
partial values from tasks are only observed in the driver if the tasks
succeeded. In the failure case we can probably just ignore the accumulators.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala, line
122
\[r3\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQdPCVVHhakQVRr-r3-122)**
([raw
file](https://github.com/apache/spark/blob/ca1811f5beb035db74e932e683716bd09e1f7302/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala#L122)):</sup>
OK, let's move the discussion here to the main thread.
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/7774)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
