Github user GraceH commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7888#discussion_r36148284
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -264,10 +264,10 @@ private[spark] class ExecutorAllocationManager(
         updateAndSyncNumExecutorsTarget(now)
     
         removeTimes.retain { case (executorId, expireTime) =>
    -      val expired = now >= expireTime
    +      var expired = now >= expireTime
           if (expired) {
    -        initializing = false
    -        removeExecutor(executorId)
    +        expired = removeExecutor(executorId)
    +        if (expired)  initializing = false
    --- End diff --
    
    I have done the style check before committing. sorry for missing the 
```if``` block here.  I will fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to