Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7139#issuecomment-127449626
Thanks @brkyvz for the update. I did one pass over the code and mostly had
minor comments. I think the idea of building a zip file at the end just before
we launch is pretty good. BTW there is some code to create the zip in Windows
at
https://github.com/apache/spark/blob/3b0e44490aebfba30afc147e4a34a63439d985c6/R/install-dev.bat#L29
that can also be cleaned up now.
BTW I'll also try to test this on Windows and see how far I get. My guess
is that if we can make the name of the R binary configurable we should be able
to get this working on windows, but we can do that in a follow up PR too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
