Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127453278
Initial thought: I don't think the user should need 2 parameters to
specify whether to use sample weights.
What if, instead, there were no default weightCol? If the user specifies
weightCol, then we use sample weights. If weightCol is unspecified or an empty
String, then we don't use sample weights. Then we could eliminate
HasWeightedSample.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
