Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/7729#issuecomment-127455561
@MechCoder thank you for the very detailed review! I have made most of the
changes that you had pointed out except for the following:
- I left the tags on the alternative constructor for the public classes as
I thought it would be useful to know when it was introduced.
- I left the tag in the DistributedMatrix as it is not a sealed trait and
would be accessible.
In addition to the above:
- I removed the tags from the hashCode and equals methods based on your
comment. The only exception is the toString method in the DenseVector and
SparseVector classes.
Let me know if you spot something else. Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
