Github user dusenberrymw commented on the pull request:
https://github.com/apache/spark/pull/7554#issuecomment-127457052
@mengxr Alright, I've updated this PR. Now, the `rows` (or `entries`)
parameter can (non-publicly) accept a Java matrix object, and we only stored a
wrapped Java matrix object for each of the classes.
Also, since we should still _internally_ document and test this for
_internal_ usage, I kept the `__init__` docstrings and expanded them to explain
the non-public feature of the `rows` (or `entries`) parameter, as well as to
test this feature. The `__init__` docstrings are not part of the publicly
generated docs, so this is a great place to put this.
Thanks, and please let me know if I can update anything else! Once this is
merged, I can finish up #7761.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
