Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/7774#issuecomment-127459568
Review status: 7 of 22 files reviewed at latest revision, 67 unresolved
discussions, all commit checks successful.
---
<sup>**[core/src/main/scala/org/apache/spark/SparkContext.scala, line 1251
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQcpLeewy2xYyOD-r4-1251)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/core/src/main/scala/org/apache/spark/SparkContext.scala#L1251)):</sup>
Done.
---
<sup>**[sql/core/src/main/resources/org/apache/spark/sql/ui/static/spark-sql-viz.js,
line 79
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJp-r4-79)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/resources/org/apache/spark/sql/ui/static/spark-sql-viz.js#L79)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala, line
122
\[r3\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQdPCVVHhakQVRr-r3-122)**
([raw
file](https://github.com/apache/spark/blob/ca1811f5beb035db74e932e683716bd09e1f7302/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala#L122)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala, line
123
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQdPCVVHhakQVRr-r4-123)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala#L123)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala, line
1881
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQdPCVVHhakQVRr-r4-1881)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala#L1881)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala,
line 62
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrl-r1-64)**
([raw
file](https://github.com/apache/spark/blob/23abf73cafac3af0363486bdae91d737e235a197/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala#L62)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala,
line 67
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrl-r1-69)**
([raw
file](https://github.com/apache/spark/blob/23abf73cafac3af0363486bdae91d737e235a197/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala#L67)):</sup>
Use the lower case `future` now. Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala,
line 64
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrm-r4-64)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala#L64)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala,
line 67
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrm-r1-65)**
([raw
file](https://github.com/apache/spark/blob/23abf73cafac3af0363486bdae91d737e235a197/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala#L67)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala,
line 130
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrj-r4-130)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L130)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala,
line 138
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQehEcEYVaSyCrj-r4-138)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L138)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala,
line 58
\[r3\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR6-r3-58)**
([raw
file](https://github.com/apache/spark/blob/ca1811f5beb035db74e932e683716bd09e1f7302/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala#L58)):</sup>
Vote for (1)
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala,
line 84
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR6-r4-84)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala#L84)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala, line
79
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQdPCVVHhakQVRt-r1-80)**
([raw
file](https://github.com/apache/spark/blob/23abf73cafac3af0363486bdae91d737e235a197/sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala#L79)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala, line
82
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQdPCVVHhakQVRt-r4-82)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala#L82)):</sup>
Right. There will be 2 tabs but both them link to the same page. Let me how
to fix it.
BTW, StreamingContext allows only one active context.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala,
line 36
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJr-r4-36)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala#L36)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala,
line 133
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-Jvpk6HAav0HqRcnGqcD)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala#L133)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala,
line 154
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvpkGDIsvkYxcFl-p1P)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala#L154)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala,
line 194
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJr-r1-191)**
([raw
file](https://github.com/apache/spark/blob/23abf73cafac3af0363486bdae91d737e235a197/sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala#L194)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala,
line 196
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJr-r4-196)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala#L196)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/ExecutionPage.scala,
line 29
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJs-r1-29)**
([raw
file](https://github.com/apache/spark/blob/23abf73cafac3af0363486bdae91d737e235a197/sql/core/src/main/scala/org/apache/spark/sql/ui/ExecutionPage.scala#L29)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/ExecutionPage.scala,
line 108
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJs-r4-108)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/ExecutionPage.scala#L108)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SparkPlanGraph.scala,
line 94
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQg1cmK3TEwSiwT-r4-94)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SparkPlanGraph.scala#L94)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SparkPlanGraph.scala,
line 98
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQg1cmK3TEwSiwT-r4-98)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SparkPlanGraph.scala#L98)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SparkPlanGraph.scala,
line 110
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQg1cmK3TEwSiwT-r4-110)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SparkPlanGraph.scala#L110)):</sup>
They have different arguments. SparkPlanGraphNode needs `metricsValue:
Map[Long, Any]` to display the latest metrics in the node label.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 38
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-38)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L38)):</sup>
I 'm not sure if the annotation will have a similar issue like #6711
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 99
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-99)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L99)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 102
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-102)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L102)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 139
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvplbxtEcRT_dHYezAz)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L139)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 168
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-168)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L168)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 258
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-258)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L258)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 270
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-270)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L270)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 295
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-295)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L295)):</sup>
Done.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 300
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-300)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L300)):</sup>
Done.
---
<sup>**[sql/core/src/test/scala/org/apache/spark/sql/ui/UISeleniumSuite.scala,
line 58
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQiuRHsztLfeN96-r4-58)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/test/scala/org/apache/spark/sql/ui/UISeleniumSuite.scala#L58)):</sup>
Done.
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/7774)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
