Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7709#discussion_r36154563
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -741,6 +742,21 @@ public static UTF8String concatWs(UTF8String 
separator, UTF8String... inputs) {
         return res;
       }
     
    +  // TODO: Need to use `Code Point` here instead of Char in case the 
character longer than 2 bytes
    --- End diff --
    
    If all the characters are less than 127, then we could use Map[Byte][Byte]( 
even Array[byte][128]), otherwise use Map[Int][Int]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to