Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7774#issuecomment-127472369
Reviewed 3 of 20 files at r1, 2 of 9 files at r3, 2 of 11 files at r4, 1 of
7 files at r5, 1 of 11 files at r6.
Review status: 7 of 22 files reviewed at latest revision, 68 unresolved
discussions, all commit checks successful.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala,
line 37
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQfuM98ojw4pcJr-r4-36)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/AllExecutionsPage.scala#L37)):</sup>
Now that this is a mutable list buffer, can it be a `val`?
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala,
line 38
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQh1eM3HWsvMBR7-r4-38)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/main/scala/org/apache/spark/sql/ui/SQLListener.scala#L38)):</sup>
We've been using these annotations throughout Tungsten so I hope that this
isn't still an issue for the shell.
---
<sup>**[sql/core/src/test/scala/org/apache/spark/sql/ui/UISeleniumSuite.scala,
line 63
\[r4\]](https://reviewable.io:443/reviews/apache/spark/7774#-JvokJQiuRHsztLfeN96-r4-63)**
([raw
file](https://github.com/apache/spark/blob/94065929603633714929c5ecbd43c2a65182552a/sql/core/src/test/scala/org/apache/spark/sql/ui/UISeleniumSuite.scala#L63)):</sup>
Okay. If we run into issues with this test then we may have to temporarily
disable it and file a followup JIRA to investigate further during the QA period
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/7774)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
