Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/956#discussion_r13576810
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -269,6 +271,22 @@ class SQLContext(@transient val sparkContext:
SparkContext)
protected abstract class QueryExecution {
def logical: LogicalPlan
+ def eagerlyProcess(plan: LogicalPlan): RDD[Row] = plan match {
+ case SetCommand(key, value) =>
--- End diff --
I'm a bit confused that the actual logic for the `set` command is not
handled in `SetCommandPhysical` but here as a special case. I think we can
remove `eagerlyProcess` and `processCmd` in this file with the help of changes
made in PR #948, so that we can move the actual processing logic of `set`
command back to `SetCommandPhysical`. @rxin @marmbrus What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
