Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7796#discussion_r36168095
  
    --- Diff: 
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
 ---
    @@ -71,14 +73,33 @@ class DirectKafkaInputDStream[
       protected[streaming] override val checkpointData =
         new DirectKafkaInputDStreamCheckpointData
     
    +
    +  /**
    +   * Asynchronously maintains & sends new rate limits to the receiver 
through the receiver tracker.
    +   */
    +  override protected[streaming] val rateController: Option[RateController] 
= {
    +    if (RateController.isBackPressureEnabled(ssc.conf)) {
    +      RateEstimator.create(ssc.conf).map { new 
DirectKafkaRateController(id, _) }
    +    } else {
    +      None
    +    }
    +  }
    +
       protected val kc = new KafkaCluster(kafkaParams)
     
    -  protected val maxMessagesPerPartition: Option[Long] = {
    -    val ratePerSec = context.sparkContext.getConf.getInt(
    +  private val ratePerPartition: Int = context.sparkContext.getConf.getInt(
           "spark.streaming.kafka.maxRatePerPartition", 0)
    -    if (ratePerSec > 0) {
    +  protected def maxMessagesPerPartition: Option[Long] = {
    +    val estimatedRate = 
rateController.map(_.getLatestRate().toInt).getOrElse(-1)
    +    val numPartitions = currentOffsets.keys.size
    +    val effectiveRatePerPartition = if (estimatedRate > 0) {
    +      Math.min(ratePerPartition, (estimatedRate / numPartitions))
    --- End diff --
    
    Can you rename `ratePerPartition` to `maxRateLimitPerPartition` to make it 
clear that its the max rate limit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to