Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/7913#discussion_r36204473
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/ReliableKafkaReceiver.scala
---
@@ -78,10 +78,10 @@ class ReliableKafkaReceiver[
private var blockOffsetMap: ConcurrentHashMap[StreamBlockId,
Map[TopicAndPartition, Long]] = null
/**
- * Manage the BlockGenerator in receiver itself for better managing
block store and offset
- * commit.
+ * A BlockGenerator managed by the receiver itself for more control over
storing blocks and
+ * committing offsets.
*/
- private var blockGenerator: BlockGenerator = null
+ private lazy val blockGenerator = supervisor.createBlockGenerator(new
GeneratedBlockHandler)
--- End diff --
The previous implementation will create a new `BlockGenerator` when
restarting the receiver. Is it safe to reuse it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
