Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/7872#issuecomment-127676478
You have a whole lot of style violations in your code. I'd recommend
starting off at:
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
You don't need to duplicate the code in `CommandBuilderUtils`. You can add
a `private[spark]` Scala class that exposes it, similar to this:
https://github.com/apache/spark/blob/3c0156899dc1ec1f7dfe6d7c8af47fa6dc7d00bf/core/src/main/scala/org/apache/spark/launcher/WorkerCommandBuilder.scala
Also, there's a lot of changes here. The original attempt at fixing this
only touched the escaping function, can you explain why do you need to touch
anything else? I don't have YARN running on Windows so I can't really test any
of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
