Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7924#issuecomment-127730179
Woah, this looks kind of complex. Why do we need to copy the next row when
freeing the page? At some point during the iteration we advance across the page
boundary and return the first row from a new page. At that point, can't we just
free the previous page? The boundary case of freeing the last page will be
handled by our existing mechanisms to free all pages at the end of the iterator
as a whole, plus the contract that the caller should call `cleanupResources()`
after they're done with the iterator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
