Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36235094
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -88,6 +88,23 @@ private[ml] trait HasLabelCol extends Params {
}
/**
+ * Trait for shared param sampleWeightCol (default: "weight").
+ */
+private[ml] trait HasSampleWeightCol extends Params {
+
+ /**
+ * Param for sample weight column name.
+ * @group param
+ */
+ final val sampleWeightCol: Param[String] = new Param[String](this,
"sampleWeightCol", "sample weight column name")
--- End diff --
Shall we call it `weightCol` and without default value? If this is defined,
use the column specified as weights. Otherwise, treat all weights as 1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
