Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7927#discussion_r36235201
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
    @@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with 
Matchers with BeforeAndAfterE
         assert(list2DiskGet.get.readMethod === DataReadMethod.Disk)
       }
     
    +  test("block manager crash test") {
    --- End diff --
    
    Can you reference a JIRA in the test title or otherwise provide more 
description of what case is supposed to be tested here? This isn't a super 
descriptive name as it stands now.  Also, the test name probably doesn't need 
to include the word "test".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to