Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7937#discussion_r36270445
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -35,83 +35,81 @@ class PrefixSpanSuite extends SparkFunSuite with
MLlibTestSparkContext {
*/
val sequences = Array(
- Array(1, -1, 3, -1, 4, -1, 5),
- Array(2, -1, 3, -1, 1),
- Array(2, -1, 4, -1, 1),
- Array(3, -1, 1, -1, 3, -1, 4, -1, 5),
- Array(3, -1, 4, -1, 4, -1, 3),
- Array(6, -1, 5, -1, 3))
+ Array(0, 1, 0, 3, 0, 4, 0, 5, 0),
--- End diff --
It increases the code complexity on boundary checks. Let's use this format
first. If the overhead is significant, we can update it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
