Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7955#discussion_r36284225
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -184,7 +187,8 @@ object GenerateProjection extends
CodeGenerator[Seq[Expression], Projection] {
public void setNullAt(int i) { nullBits[i] = true; }
public boolean isNullAt(int i) { return nullBits[i]; }
- protected Object genericGet(int i) {
+ @Override
+ public Object genericGet(int i) {
--- End diff --
I made `SpecificRow` extends `CodeGenMutableRow` which mix-in
`BaseGenericInternalRow`, so that we don't need to codegen all special getters
inside `SpecificRow`.
The `genericGetter` should be `protected` here, but seems it's a scala
mix-in bug that I have to use public.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
