Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7973#discussion_r36353952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -68,6 +65,8 @@ case class SortMergeJoin(
leftResults.zipPartitions(rightResults) { (leftIter, rightIter) =>
new Iterator[InternalRow] {
+ // An ordering that can be used to compare keys from both sides.
+ private[this] val keyOrdering =
newNaturalAscendingOrdering(leftKeys.map(_.dataType))
--- End diff --
How about we at a comment at
https://github.com/apache/spark/pull/7973/files#diff-b669f8cf35f1d2d786582f4d8c49ed14R59
to explain the direction must be `Ascending`. So, the direction in
`requiredOrders` is consistent with the direction we are using at here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
