Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7839#discussion_r36353966
  
    --- Diff: 
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
 ---
    @@ -252,4 +273,19 @@ public String toString() {
             .toString();
         }
       }
    +
    +  /**
    +   * write out the set of registered executors to a file so we can reload 
them on restart.
    +   * You must have a lock on executors when calling this
    +   */
    +  private void saveRegisteredExecutors() throws IOException {
    +    if (registeredExecutorFile != null) {
    +      File tmp = new File(registeredExecutorFile.getAbsolutePath() + 
".tmp");
    +      ObjectOutputStream out = new ObjectOutputStream(new 
FileOutputStream(tmp));
    +      out.writeObject(executors);
    +      out.close();
    --- End diff --
    
    This needs to be in a `finally` block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to