Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7538#issuecomment-128162888
> Are we planning to have a MulticlassLogisticRegressionSummary inheriting
from LogisticRegressionSummary in the future because without that I'm unable to
understand how using a trait would help since there is no access to the
predictions dataframe.
Yes, MulticlassLogisticRegressionSummary should be analogous to the binary
version, with both inheriting from LogisticRegressionSummary.
> can you give a concrete example of how not using a sealed trait will
break the API?
Adding a method to a trait is a breaking API change. If a user has
implemented some class which extends the trait, then adding a method to the
trait will mean the user's class will no longer implement all of the methods it
needs to. Marking it sealed will prevent users from extending the trait so
that we can add more methods in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
