Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7954#discussion_r36383162
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
 ---
    @@ -256,12 +256,16 @@ case class Sum(child: Expression) extends 
AlgebraicAggregate {
       override def dataType: DataType = resultType
     
       // Expected input data type.
    +  // TODO: Once we remove the old code path, we can use our analyzer to 
cast NullType
    --- End diff --
    
    which old path are we talking about? the "old" aggregate code path is not 
using sum here, is it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to