Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7978#discussion_r36432655
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -87,12 +87,16 @@ public static int calculateBitSetWidthInBytes(int
numFields) {
public static boolean isFixedLength(DataType dt) {
if (dt instanceof DecimalType) {
- return ((DecimalType) dt).precision() < Decimal.MAX_LONG_DIGITS();
+ return ((DecimalType) dt).precision() <= Decimal.MAX_LONG_DIGITS();
} else {
return settableFieldTypes.contains(dt);
}
}
+ public static boolean isSettable(DataType dt) {
--- End diff --
I use `isMutable` in the begging, but the set is called
`settableFieldTypes`, we should rename them as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
