Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7266#discussion_r36439156
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala 
---
    @@ -53,6 +53,8 @@ private[shared] object SharedParamsCodeGen {
           ParamDesc[Int]("checkpointInterval", "checkpoint interval (>= 1)",
             isValid = "ParamValidators.gtEq(1)"),
           ParamDesc[Boolean]("fitIntercept", "whether to fit an intercept 
term", Some("true")),
    +      ParamDesc[String]("handleInvalid", "how to handle invalid entries",
    --- End diff --
    
    Please make docs more explicit.  It's very helpful to users.  Here, it'd be 
nice to state the options and what they mean: "Options: skip (filter out rows 
with bad values) or error (throw an error).  Note that skipping rows means the 
Transformer can output a smaller dataset."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to