Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/718#discussion_r13620284
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
 ---
    @@ -67,10 +69,29 @@ private[spark] class HistoryServerArguments(args: 
Array[String]) {
     
       private def printUsageAndExit(exitCode: Int) {
         System.err.println(
    -      "Usage: HistoryServer [options]\n" +
    -      "\n" +
    -      "Options:\n" +
    -      "  -d DIR,  --dir DIR     Location of event log files")
    +      """
    +      |Usage: HistoryServer [-d logDir]
    +      |
    +      |The preferred way to pass options is to set the configuration below 
using
    +      |SPARK_HISTORY_OPTS. The "-d" command line argument is avalable for 
backwards
    --- End diff --
    
    Not sure if we want to say this, actually. Right now the 
`start-history-server.sh` script still expects a logging directory, which uses 
the now "deprecated" way as of this PR. I would either remove this comment or 
change the way we use the script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to