Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7447#issuecomment-128524994
@Lewuathe Thanks for the update. Looking at this again, I've become more
convinced that the check should piggy-back on other tests. For most models, it
fits naturally with the standard ParamsSuite.checkParams check. For a few
models, it's pretty expensive to add a unit test which requires fitting a new
model. Could you please put the check into existing unit tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
