Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7988#discussion_r36479331
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -95,6 +95,22 @@ sealed trait Partitioning {
def guarantees(other: Partitioning): Boolean
}
+object Partitioning {
+ def allCompatible(partitionings: Seq[Partitioning]): Boolean = {
+ // Note: this assumes transitivity
+ partitionings.sliding(2).map {
+ case Seq(a) => true
+ case Seq(a, b) =>
+ if (a.numPartitions != b.numPartitions) {
+ assert(!a.guarantees(b) && !b.guarantees(a))
--- End diff --
This sounds good to me. Let's revisit this naming later once we actually
break this symmetry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
