Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7957#discussion_r36485528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -955,6 +957,18 @@ class Analyzer(
Project(p.output, newPlan.withNewChildren(newChild :: Nil))
}
}
+
+ object CleanAlias extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan
transformAllExpressions {
+ case UnresolvedAlias(child) => child match {
+ case g: GetStructField => Alias(g, g.field.name)()
--- End diff --
Sorry I made a mistake here, we should just remove the `UnresolvedAlias`,
just like what we did in `Analyzer.ResolveReferences`(we call
`trimUnresolvedAlias` there).
The key problem is we have 2 code path to resolve `UnresolvedAttribute`,
one is `Analyzer.ResolveReferences`(last case) and the other is
`DataFrame.resolve`, so we need to make them consistent, i.e. call
`trimUnresolvedAlias` at `DataFrame.resolve` or abstract this logic for sql and
dataframe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
