Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7904#discussion_r36495504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/OuterJoin.scala ---
@@ -111,52 +122,43 @@ trait HashOuterJoin {
// iterator for performance purpose.
protected[this] def leftOuterIterator(
- key: InternalRow,
joinedRow: JoinedRow,
rightIter: Iterable[InternalRow],
resultProjection: InternalRow => InternalRow): Iterator[InternalRow]
= {
val ret: Iterable[InternalRow] = {
- if (!key.anyNull) {
- val temp = if (rightIter != null) {
- rightIter.collect {
- case r if boundCondition(joinedRow.withRight(r)) =>
resultProjection(joinedRow).copy()
--- End diff --
This problem existed in the old code, but I should fix it here: I don't
think that we need to perform this `copy()` here.
Also, I don't see why we need to construct `val ret: Iterable[InternalRow]`
here only to turn around and immediately call `ret.iterator` on it. This seems
like it will cause a lot of inefficient copying and materialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
