Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7904#discussion_r36560364
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/OuterJoin.scala ---
@@ -111,52 +122,43 @@ trait HashOuterJoin {
// iterator for performance purpose.
protected[this] def leftOuterIterator(
- key: InternalRow,
joinedRow: JoinedRow,
rightIter: Iterable[InternalRow],
resultProjection: InternalRow => InternalRow): Iterator[InternalRow]
= {
val ret: Iterable[InternalRow] = {
- if (!key.anyNull) {
- val temp = if (rightIter != null) {
- rightIter.collect {
- case r if boundCondition(joinedRow.withRight(r)) =>
resultProjection(joinedRow).copy()
--- End diff --
Just pushed an update which removes this use of `flatMap`, `collect` and
partial functions for SMJ outer join. Since SMJ outer join no longer relies on
these changes in OuterJoin I'm going to back out all of the other now-unrelated
changes to the other outer join operators. We can pursue optimization of those
other joins as part of a followup patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
