Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8018#discussion_r36581816
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/decimal/DecimalSuite.scala
---
@@ -46,11 +46,8 @@ class DecimalSuite extends SparkFunSuite with
PrivateMethodTester {
checkDecimal(Decimal(1e17.toLong, 18, 0), 1e17.toLong.toString, 18, 0)
checkDecimal(Decimal(Long.MaxValue), Long.MaxValue.toString, 20, 0)
checkDecimal(Decimal(Long.MinValue), Long.MinValue.toString, 20, 0)
- intercept[IllegalArgumentException](Decimal(170L, 2, 1))
--- End diff --
This patch has change to use Decimal(unscaleLong, precision, scale) only
for serialization, and the caller will make sure that it will not overflow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
