GitHub user BertrandDechoux opened a pull request:
https://github.com/apache/spark/pull/8062
[SPARK-9720] [ML] Identifiable types need UID in toString methods
A few Identifiable types did override their toString method but without
using the parent implementation. As a consequence, the uid was not present
anymore in the toString result. It is the default behaviour.
This patch is a quick fix. The question of enforcement is still up.
No tests have been written to verify the toString method behaviour. That
would be long to do because all types should be tested and not only those which
have a regression now.
It is possible to enforce the condition using the compiler by making the
toString method final but that would introduce unwanted potential API breaking
changes (see jira).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Influans/spark SPARK-9720
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8062.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8062
----
commit f2fc5fde7a8d8ef6415e066ec14de2dace747d32
Author: Bertrand Dechoux <[email protected]>
Date: 2015-08-09T17:06:59Z
[SPARK-9720] [ML] Identifiable types should (still) have UID in toString
methods
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
