Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8014#discussion_r36592402
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -251,6 +251,13 @@ private[spark] object JettyUtils extends Logging {
private def attachPrefix(basePath: String, relativePath: String): String
= {
if (basePath == "") relativePath else (basePath +
relativePath).stripSuffix("/")
}
+
+ /**
+ * Attach a prefix to the given path, don't remove the trailing / if
present.
+ */
+ private def attachPrefixForRedirect(basePath: String, relativePath:
String): String = {
--- End diff --
Both of these methods seems superfluous. They're trivial and each called
once. I don't see why `basePath == ""` is treated separately, like, why the
trailing slash wouldn't be stripped. In fact, there's only one way a call sets
`basePath` to anything but `""` and it's the `/jobs` servlet below - not clear
why only that is special cased?
Anyway I'd suggest removing the methods and removing the special-casing --
it's just the combination of two strings, with a trailing / stripped in one
case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
