Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8060#discussion_r36594052
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregate.scala
---
@@ -63,7 +68,13 @@ case class SortBasedAggregate(
}
protected override def doExecute(): RDD[InternalRow] = attachTree(this,
"execute") {
- child.execute().mapPartitions { iter =>
+ val numInputRows = longMetric("numInputRows")
+ val numOutputRows = longMetric("numOutputRows")
+ child.execute().mapPartitions { _iter =>
+ val iter = _iter.map { row =>
--- End diff --
it'd be great if we can avoid the extra iterator map, because an iterator
wrapper actually introduces a lot of overhead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
