Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8033#issuecomment-129592820
> Is the point to get rid of implicits only, or also replace
JavaConversions with JavaConverters? I wasn't sure whether the latter is
preferred.
The point is to get rid of `JavaConversions`, since that makes it really
hard for code-reviewers to spot when inefficient implicit conversions are
taking place. There are many places where performing these conversions _does_
make sense, such as in some of the Java API wrappers, and in those cases I'd
prefer that we use the explicit `.toJava` and `.toScala` methods from
JavaConverters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
