Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8077#issuecomment-129621418
Note (not requiring changes): I had meant for the default gammaShape to be
defined in the abstract LDAModel, in order to improve (but not fix) binary
incompatibility issues for anyone who extended LDAModel. However, I just
noticed that LDAModel has a private constructor, so we don't need to worry
about binary incompatibility. So feel free to arrange gammaShape however you
like. I think the current setup is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
