Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7447#issuecomment-129642654
@Lewuathe I realized my suggestion of including the check within the Params
check was not a good idea since those checks create models without parents.
(The parent check therefore just ensures that null equals null.) Sorry for
asking for yet another update, but could you please update the tests to
piggy-back off of other tests which create models via fit()? Those tests will
create models with actual parents, so that the checkCopy() method will do a
reasonable test. Please let me know if this makes sense to you.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
