Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8033#discussion_r36771152
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
---
@@ -38,7 +38,7 @@ object LogisticRegressionSuite {
scale: Double,
nPoints: Int,
seed: Int): java.util.List[LabeledPoint] = {
- seqAsJavaList(generateLogisticInput(offset, scale, nPoints, seed))
+ seqAsJavaListConverter(generateLogisticInput(offset, scale, nPoints,
seed)).asJava
--- End diff --
Oh! I seem to have overlooked this entirely, that the point of
`JavaConverters` is that the "xAsY" functions are still implicit. Well this
will clean this up a lot. Thanks for pointing that out before I got too far. It
won't be hard to touch this up in the changes so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
