Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7943#discussion_r36773114
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -252,4 +338,118 @@ public String toString() {
.toString();
}
}
+
+ static ObjectMapper mapper = new ObjectMapper();
+
+ private static byte[] dbAppExecKey(AppExecId appExecId) throws
IOException {
+ // we stick a common prefix on all the keys so we can find them in the
DB
+ String appExecJson = mapper.writeValueAsString(appExecId);
+ String key = (APP_KEY_PREFIX + ";" + appExecJson);
--- End diff --
Is the prefix needed? It doesn't seem like you're using it for anything
(since you just discard it in the parse method).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
