Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8087#issuecomment-130137919
Actually, I'm going to switch the design to instead:
* accept a single check method which will use assertions
* catch AssertionErrors when deciding whether we can terminate
* throw the last caught AssertionError upon timeout
That will allow us to (a) avoid copying the set of checks and (b) take
advantage of the many assertion variants, including approximate equality.
AFAIK, the overhead in catching errors should be negligible compared to the
time for the tests. (Correct me if I'm wrong here.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
