Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8116#issuecomment-130141381
The basic fix here looks good to me, although you might consider using the
TaskContext callback approach to ensure eventual cleanup. We do this inside of
the UnsafeExternalSort (or one of the sort operators, maybe the SQL-specific
parts) to ensure spill files are cleaned up if a limit is placed after a sort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
