Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1014#discussion_r13682900
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -579,6 +598,23 @@ class ALS private (
}
}
+/**
+ * Partitioner for ALS.
+ */
+private[this] class ALSPartitioner(override val numPartitions: Int)
extends Partitioner {
--- End diff --
Does `private[this]` make sense at the top level? Shouldn't it be
`private[recommendation]` or something like that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---